Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge main #80

Merged
merged 2 commits into from
Sep 14, 2023
Merged

merge main #80

merged 2 commits into from
Sep 14, 2023

Conversation

yabuta
Copy link
Collaborator

@yabuta yabuta commented Sep 14, 2023

Related Issue(required)

Description(required)

Review Procedure(required)

Related PR(optional)

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

If you are adding new package following items are required:

  • Documentation with description of the package is available
  • A sample launch file and parameter file are available if the package contains executable nodes

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets
  • Write release notes

tkhmy and others added 2 commits September 13, 2023 13:26
* add slow stop

Signed-off-by: tkhmy <[email protected]>

* clean up

Signed-off-by: tkhmy <[email protected]>

* update phrases

Signed-off-by: tkhmy <[email protected]>

* change condition

Signed-off-by: tkhmy <[email protected]>

* fix typo

Signed-off-by: tkhmy <[email protected]>

* fix typo

Signed-off-by: tkhmy <[email protected]>

* add slwoing down

Signed-off-by: tkhmy <[email protected]>

---------

Signed-off-by: tkhmy <[email protected]>
@yabuta yabuta requested a review from tkhmy September 14, 2023 01:39
@yabuta yabuta merged commit f1763b4 into main Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants